amazing, @TrySound will have a look
Please reference the issue in the pr and write a title in a way it would make sense in the changelog to any person who isn't as deeply involved, because we have automated the release process, titles are changelog entries
Oh I just looked you already added a ref and title looks good
Does it usually takes up to 3-4 seconds for the hot refreshing to happen to you?
locally to me its nearly instant
what about you @TrySound ?
at least 6 seconds most of the time ... crazy for me
it could be my computer thou ... I am gonna be force to have one laptop-docker-host setup to run all the services of my setup... (welcome to docker life)
Remix is not very flexible compiler
I'm on intel. You can guess
I am on Intel also, hackintosh, so even more powerful than regular Macbooks
still ... really slow and the compiler sometimes just fail to build files and whatnot :sobpike:
That is pretty bad, recently @Ivan Starkov had a 40x improvement there by removing one thing that was watching too many files. I wonder if it works well for you now @Ivan Starkov
@Oleg Isonen fixng the PR, I tried to figure out how to use the theme but I needed a raw px value
the type of the theme is string while the component expects number
yep, this is not a good way to deal with this, not sure if you or @TrySound has a better idea, I already had to use parseFloat for this in help-popover ... and I am not loving the idea of these being used widely
We could switch to having a theme without units, but it would be partially inconsistent when you need other units than px in the theme
I think the actual problem here is that those values should have separately the value and the unit
as long as things are always declarative (not runtime craziness), and statically defined (came from somewhere controlled, no magic values)
meh, come back to it later, hopefully TS helps to figure out the situation
well, the tricky is radix thou!
Why px? that is the underline problem here.
What it means to have "a value", and how these GUI libs forces you to conform to a given way to work
I am relative-positioning junky, so every time I see a pixel I lose it :KEKW:
maybe we could use
const something = UnitValue(10, 'px') ;
something.toString() //10px
something.value // 10
something. unit // 'px'
It would be backwards compatible, stitches would just use the string version I believe (need to test though)
yeah, radix asking for a number in px is not ideal, but it might be required because they calculate things, its not just plain css value
I looked at what they did using the transform, I get it I guess
Less ideal for sure, I tried what you suggest before, if and only if you do not end up having to deal with so many crazy stuff from 3rd party libs, it could work.
I done that before, and at some point, I ended up creating such complex object that had to convert to rem em px. ... you named it
CI is failing btw, the visual regression stuff
I wouldn't be doing any conversion there
I get it I get it, just sharing that hopefully you do not come across another Radix, asking you to pass some weird value LOL
:sobpike: do not ask me why I bring it up :lolsob:
I just tried, seems to work, preparing a pr
btw,
https://github.com/webstudio-is/webstudio/issues/1892 is an example, and please take it with good faith, not trying to demand more work from you. Just trying to help.
Ideally, attach a video and screenshot in terms of whatever those things mean. Videos help to figure out what steps I need to take to know what section of the app you are talking about.
As a habit, maybe record the screen and share it if you feel it isn't much work.
External contributors will be able to help you faster in some cases.
yeah ,we are just moving so fast that we don't have time to create proper issues, but when the issue is not clear we need to refine the description with whatever means necessary
So just ping us when its not clear, ask questions, we refine
We will get better at this anyways
Most of the design related things assume the basic understanding of our figma files, which are well structured
We need to get ready for more contributors though and start assuming less knowledge
quick and dirty videos have more context than writing, I found. I started to adopt the habit lately, especially internal (where I tested), and it feels pretty good not having to write for a living LOL.
Combined with some local scripts I have with ChatGTP to extract the text and create a summary jeje
yeah, we might need to experiment to find a perfect format, won't work for everyone on the team with non-native english skill
you will get there! little by little
